Few bugs etc.

dezet994

Yeah, i know, it's me again. 😛
I found few bugs, so i though i will open a thread where i will be posting all the issues i find, instead of opening new thread for each one - unless you prefer other way.

player.applyDamage()

In docs you wrote it doesn't require 2nd parameter, but it actually does. Leaving null or false doesn't work.

Frequency.Highter

Higher - Just a typo 😉

Lag on large maps

I'm not sure, but to me it looks like it's issue with the client. Probably whole map is being rendered even if only part is visible. I know browser is not perfect for huuuuge maps, but it would be awesome if it would deal with at least 6 layers of 100x100 tiles 😉

Chat sending messages twice

It's due to player.on('chat-message') listener in onJoinMap() hook - sometimes it occurs when character is teleported to the same map. In my case the reason was Title-screen, which causes character to connect and join the map before even signing in - i had to teleport character on each login to coordinates from database. Of course it's enough to put simple if, or move it to onConnect, but i bet sooner or later someone will have this issue again.

Not working on chrome

As soon as i'll replace default map with a custom made map, chrome stops rendering the game - GUI does work, console doesn't display any error. Maybe it's something wrong with my tilesets? Tried few, every time same story:
screenshot
It's even weirder considering that both chrome and opera are chromium based o.0

There will be more, so please have a look from time to time. 🙂
I hope you're not getting nuts from my constant posts 😃 😃

Samarium

Thank you very much!

I'll add the feedback on Github to make the corrections

I hope you're not getting nuts from my constant posts

On the contrary, it allows to advance the project and to leave the Beta version 👍️

Samarium

Not working on chrome

Can you share your map with me to test the problem?

I would need the tileset and the map in TMX format

dezet994

Yes, give me few minutes, i just started to break it 😃
screenshot

Btw, do we have something like private message here? I would prefer not to upload rip offs 😛

Samarium

Thanks, I'm looking into it

I deleted your message

Samarium

After testing, the samplemap and samplemap2 maps work on Chrome on my side

Edit: it can be related to the size of the map

dezet994

Hmm, probably i messed something up. ;P

dezet994

Sometimes game crashes while colliding with circle block. Console returns "toPolygon() is not a function" in Hit.js:

testPolyCollision(type, hit1, hit2) {
        let collided = false;
        switch (type) {
            case 'box':
                collided = sat_1.default.testPolygonPolygon(hit1.toPolygon(), hit2.toPolygon());
                break;
            case 'circle':
                collided = sat_1.default.testPolygonCircle(hit1.toPolygon(), hit2);
                break;
            case 'polygon':
                collided = sat_1.default.testPolygonPolygon(hit1, hit2.toPolygon());
                break;
        }
        return collided;
    }

Ps: side question to not open a new thread. I would like to know if you could (and are going to) optimize somehow big map lag in the closest future? Once again, i'm not pushing, i just want to know if there is a point to make larger maps 😉

Samarium

Thanks for the feedback.
For the big maps, I have to find the problem first.
If it's related to the server reconciliation, then the problem will be fixed soon. If not, it will take more time

dezet994

Samarium Thanks bro 🙂
Please, let me know when you will know something, regardless the outcome.

dezet994

I didn't notice before, but problem happens only during the movement.
video

It also doesn't happen in left-top corner (idk why), but the closer to the middle i'm getting, the worse lags.

Edit:// Actually it depends from start position. If i'll put start in the middle, game works quickly in the middle. The further from start point i get, te bigger lags during walk i get. What's also interesting, every time i will return to area of starting point, game starts to work quickly again.

Samarium

I don't think the problem is related to the size of the map but to code instructions that slow down the processor.
With you in onInput loops that run on character movement?

dezet994

Hey, i commented out all onInput methods, without success.
Anyway, i have 8 cores 16 threads ryzen overclocked to 4 ghz, i don't think it's cpu issue.

dezet994

Ehh, i found a solution... Quite stupid of me 😃
In onChanges (RpgSprite) i called a method without verifying if data really changed, so it was called few times per step... ;D

Anyway, thanks again for support. 🙂
Btw, maybe you should limit calling the onChanges method to x times per second?

Samarium

In fact, onChanges is called every time the player's property changes. Here, it was the X and Y positions

Anyway, it shows that the size of the map was not the problem here 😉
I remove from the bug list 😄

dezet994

Yea, i didn't really expect this, as i'm always trying to check stuff like this. Anyway, consider throttling it a little bit. If we have around 30 NPCs on the map + each tile has for example 32x32, then onChanges caused by random movements might be called too often 😉 Actually i never seen anything on my PC to get so laggy so far, so i think it's worth attention 😃

Look at the video - it's just 2 NPCs on this map.

Edit:// With 30 NPCs on the map there is a huge lag between client and server. Also NPCs movement gets weird, instead of whole tile they go few pixels and change direction, although here i'm not sure if it's not something on my side.

Samarium

Yes, the benchmarks show the same thing. In fact, the number of events on a map takes performance.
It is mainly because of the collision searches on the other events that cause lags.
I've thought about several points to remedy this, which theoretically would allow not to be blocked by the number of events on a map

dezet994

Maybe, i didn't finish my map so i've got no ready collisions. But the fact, that onChanges method is triggered ~ 30 times during one tile step done by NPC needs attention 😉 Throttling it will definitely increse performance and probably remove lag/jump between client server

dezet994

Another one: I think in documentation (https://docs.rpgjs.dev/classes/client-engine.html#rpgenginehooks) instead of RpgEngineHooks should be RpgClientEngineHooks